-
Notifications
You must be signed in to change notification settings - Fork 12
add more color and regexps: #16
base: master
Are you sure you want to change the base?
Conversation
add header tag to index add regexps for files overview new file mode line deleted file mode line mail header add color to range and coordinates header meta separater mail header
Hello! Thanks for contributing. |
so that multi-line commit messages don't look weird
In the example I made the colors might seem like a lot in your face but on changes with more than just one line, the color of the headers and ranges make it easier to find the boundaries between commits The mail header color is just to set it slightly apart from the rest of the file The newfile and deletefile modes did not used to match the color of the header which seemed off to me so that is fixed in this patch I guess I just thought it would be pretty to color the pluses and minuses in the file overview part because I've seen that somewhere before I created an example patch demonstrating the changes I made but I don't know how to attach it to this... |
I added a txt extension to it that hopefully you can just delete and it will behave the same? |
Hi @anyaharter97 ! I tried out the patch, and I think there's some considerations that aren't captured - could you take a pass at adding specs for the situations added in the diff.cson Here's an example of a spec that confirms a specific capture is being categorized correctly: language-diff/spec/diff-spec.coffee Lines 35 to 39 in 37b7dfb
This becomes helpful to leverage when tweaking regexps - and you can run the tests via Also - curious why you would add new regexps for things that don't have colors added to them - are you using the scope for something else? |
add header tag to index
add regexps for:
add color to: